Skip to content

Change Debug.WriteLine to Console.WriteLine #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 4, 2021
Merged

Change Debug.WriteLine to Console.WriteLine #10

merged 4 commits into from
May 4, 2021

Conversation

@edleno2
Copy link
Contributor

@edleno2 edleno2 commented May 4, 2021 •
edited by josesimoes
Loading

Description

  • Replace Debug.WriteLine with Console.WriteLine.

Motivation and Context

How Has This Been Tested?

Tested using the test bench that is linked in the issue.

Built on VS2019 using the test bench. Confirmed that DebugLogger output now shows in the Visual Studio Debug Output window.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

edleno2 added 3 commits May 3, 2021 18:42
@edleno2
Changed nfproj to sign the assembly
2ee89e4 
Signing this assembly so we can give it access to System namespace via nanoFramework.Core.  A later change will replace the Debug.WriteLine to Console.WriteLine so we can build a Production version of the Nuget library but still be able to output to the debugger.

Fix #737

Signed-off-by: Ed Lenoir <[email protected]>
@edleno2
Use Console.WriteLine instead of Debug.WriteLine
3445c74 
Debug.WriteLine will be no-op'd by the compiler on Release builds, and all Nuget packages are Release builds.  nanoFramework.Core has been changed to allow this library to access protected classes, like System.Console.  Using Console.WriteLine will work on both Release and Debug builds of this library.

Fix #737
@edleno2
Merge branch 'debuglogger-issue737part2' into develop
660675f
@nfbot
Copy link
Member

nfbot commented May 4, 2021

Hi @edleno2,

😞 You have to make up your mind on how this PR addresses the issue. It either fixes, closes or resolves it. Can't have them all...

@nfbot nfbot added the Type: bug Something isn't working label May 4, 2021
josesimoes
josesimoes approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes enabled auto-merge (squash) May 4, 2021 17:39
@josesimoes josesimoes merged commit 01e2b92 into nanoframework:develop May 4, 2021
@josesimoes josesimoes mentioned this pull request May 14, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees

No one assigned

Labels

Type: bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DebugLogger class does not write to Debug window

3 participants

@edleno2 @nfbot @josesimoes